Forces refresh of a FileObject after the LSP client reports the file has been saved. #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
LSP
lahodaj
approved these changes
Sep 13, 2024
Yes, the answer to on-reload question is API-branded to "yes" in the NBLS distribution. |
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the LSP client makes file changes, and then immediately performs some NBLS operation, the NBLS currently does not get a timely file change event. This PR enables
didSavenotification that forces a FileObject refresh, firing appropriate events.Somewhat controversial is the wait for reloading task, so the affected editor is reloaded before a next instruction (i.e. text modification) is received from the LSP commnand stream.