Prevent nblogger from dying on errors during format. #7741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During bug hunting in NBLS, I run into a very funny situation where the logging of NBLS suddenly stopped. It eventually resumed after a looooong time, but only sometimes.
I debugged into it and found out that some Google commons class was missing which was not used at runtime at all - except to print out JSON-RPC message from NBLS. If that happened, the message formatting failed with an
Error(rather thanExceptionthat is handled in `java.util.logging.Formatter.formatMessage. This led to death of the log publishing thread. The thread eventually resumed when the buffer was full - but dies again on another 'unformattable' message.This PR adds additional wrapper that catches everything except
ThreadDeathand prevents the logging thread from dying.