CPPLite: Improve configuration of clangd/CCLS #7758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configured before execution If both ccls and clangd had a path configured, but only the clangd one pointed to a usable binary, the clangd one was not used. To improve this, now not only the existence of the ccls path is checked, but also whether it points to an executable file.
If both CCLS and clangd are installed, switching from CCLS to clangd requires users to input an invalid path to use clangd, else CCLS is always preferred. This change allows the user to override the preferred order.
matthiasblaesing
added
LSP
|
I intent to merge this next weekend. If anyone wants to object, now would be a good time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if language server is executable, not only if path is configured before execution
If both ccls and clangd had a path configured, but only the clangd one pointed to a usable binary, the clangd one was not used. To improve this, now not only the existence of the ccls path is checked, but also whether it points to an executable file.
Make it possible to select language server
If both CCLS and clangd are installed, switching from CCLS to clangd requires users to input an invalid path to use clangd, else CCLS is always preferred.
This change allows the user to override the preferred order.
In the GUI: