cdnjs: Support handling of resources with embedded slashes afte e6b5e0d #7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With commit e6b5e0d java.io.File.createTempFile was replaced by java.nio.file.Files.createTempFile. The latter has better security properties, but fails to handle prefixes/suffixes, that contain slashes and instead raises an exception. The temporary files don't need files, that follow the names of their base resources, so with this commit the tempfiles are created with fixed prefixes and suffixes. Closes: apache#7783
matthiasblaesing
added
JavaScript
mbien
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
code looks good, sorry for the trouble
I believe the reason why it used to work is this:
https://github.com/openjdk/jdk/blob/a02d895f7ad59fe33f8a761dbd7bceb0b8dfefc0/src/java.base/share/classes/java/io/File.java#L2044-L2045
its an impl detail (possibly security fix?) which essentially drops everything except the filename, so if you add a path as prefix it is ignored.
so File.createTempFile("a/b", "hugo") becomes b2136422930822303311hugo (also interesting that it requires a 3+ char prefix, but the example above reduces it to 1)
|
@mbien thanks for checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With commit e6b5e0d java.io.File.createTempFile was replaced by
java.nio.file.Files.createTempFile. The latter has better security
properties, but fails to handle prefixes/suffixes, that contain
slashes and instead raises an exception.
The temporary files don't need files, that follow the names of their
base resources, so with this commit the tempfiles are created with
fixed prefixes and suffixes.
Closes: #7783