Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self sampler for LSP server code completion #7815

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Oct 1, 2024

This attempts to add user-configurable self sample for code completion in the VS Code extension, the sample CC invocations that are too long. If the given time (by default 10s) is elapsed, the snapshot is saved, and a warning is shown to the user.

@lahodaj lahodaj added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Oct 1, 2024
@lahodaj lahodaj added this to the NB24 milestone Oct 1, 2024
@lahodaj lahodaj requested review from jtulach and dbalek October 1, 2024 15:57
Copy link
Contributor

@jtulach jtulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am looking forward to submit as many bug reports with .npss files as possible. Thank you, Honzo!

@lahodaj
Copy link
Contributor Author

lahodaj commented Oct 15, 2024

Thanks! Unless there are objections, I'll merge in the next day or so.

@lahodaj lahodaj force-pushed the java-lsp-server-completion-sampler branch from 53a1bec to 2c778f1 Compare October 17, 2024 07:25
@lahodaj lahodaj merged commit b24ffa6 into apache:master Oct 17, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants