Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom dependency update hint could also check annotation processors #7860

Merged

Conversation

mbien
Copy link
Member

@mbien mbien commented Oct 9, 2024

java/maven.hints

  • this will show dep update hints for annotation processors declared in plugin/configuration/annotationProcessorPaths/*
  • had to update the implementation slightly since the list items didn't implement VersionablePOMComponent
  • auto completion is not implemented for this path

java/maven.model

  • removed duplicated friend declaration

example:

    <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.13.0</version>
        <configuration>
            <compilerArgs>
                <arg>-Xlint</arg>
            </compilerArgs>
            <annotationProcessorPaths>
                <path>
                    <groupId>org.hibernate.orm</groupId>
                    <artifactId>hibernate-jpamodelgen</artifactId>
                    <version>6.6.0.Final</version>  <!--  hint should appear if a newer version is known -->
                </path>
            </annotationProcessorPaths>
        </configuration>
    </plugin>

 - this will show dep update hints for annotation processors declared
   in 'plugin/configuration/annotationProcessorPaths/*'
 - had to update the implementation slightly since the list items
   didn't implement VersionablePOMComponent
 - auto completion is not implemented

java/maven.model

 - removed duplicated friend declaration
@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Oct 9, 2024
@mbien mbien added this to the NB24 milestone Oct 9, 2024
@mbien mbien requested a review from matthiasblaesing October 9, 2024 20:59
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you.

@mbien mbien merged commit 4d6ddb4 into apache:master Oct 10, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants