Make FlatLaf module standard not autoload #7882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcsmith-net
added
Look and Feel
Platform
eirikbakke
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple change. The FlatLaf module should not be autoload. This causes a bunch of confusion when people are using parts of the platform cluster without
core.kit. The FlatLaf module does not enable when included unless a non-API dependency is declared on it (which in the Maven build also requires change of scope or disabling validation).See eg. https://lists.apache.org/thread/dkpmgwo4m15ndpw0hbz9rf8rgbglbk1k although it's come up before https://lists.apache.org/thread/n97kj9fmzl0whjr74y3kpcvhocmljwjq