-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "LSP: Speed up publish diagnostics on project scan." #7982
Conversation
This reverts commit ec8384f.
Alternative PR: #7983 |
|
will needs conflict resolution first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pushing on this. Based on delivery, I merged #7999 and #7982 in that order. That unsurpringsly worked correctly (the first reverting the first fix try, that prevented the next revert to apply, the latter reverting the offending change itself).
The resulting build successfully loaded all modules from enterprise
, java
and webcommon
cluster, without raising an exception.
So assuming the final merge order will be the one described above, from my POV this is good to go.
Thanks again.
Revert "LSP: Speed up publish diagnostics on project scan."
This reverts commit ec8384f from #7737
fixes #7981