Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "LSP: Speed up publish diagnostics on project scan." #7982

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Nov 23, 2024

This reverts commit ec8384f from #7737

fixes #7981

@mbien mbien added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests Regression This used to work! ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 23, 2024
@mbien mbien added this to the NB24 milestone Nov 23, 2024
@mbien mbien linked an issue Nov 23, 2024 that may be closed by this pull request
@mbien mbien removed the ci:all-tests [ci] enable all tests label Nov 23, 2024
@apache apache locked and limited conversation to collaborators Nov 23, 2024
@apache apache unlocked this conversation Nov 23, 2024
@lahodaj
Copy link
Contributor

lahodaj commented Nov 23, 2024

Alternative PR: #7983

@mbien
Copy link
Member Author

mbien commented Nov 25, 2024

closing in favor of the above hotfix further testing revealed that the hotfix didn't fix the problem fully

@mbien mbien closed this Nov 25, 2024
@mbien mbien reopened this Nov 26, 2024
@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Nov 26, 2024
@mbien mbien marked this pull request as ready for review November 26, 2024 21:56
@ebarboni
Copy link
Contributor

will needs conflict resolution first.

@mbien
Copy link
Member Author

mbien commented Nov 27, 2024

@ebarboni the conflicts should resolve itself once the hotifx (#7983) is reverted

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing on this. Based on delivery, I merged #7999 and #7982 in that order. That unsurpringsly worked correctly (the first reverting the first fix try, that prevented the next revert to apply, the latter reverting the offending change itself).

The resulting build successfully loaded all modules from enterprise, java and webcommon cluster, without raising an exception.

So assuming the final merge order will be the one described above, from my POV this is good to go.

Thanks again.

@ebarboni ebarboni merged commit ffe785c into apache:delivery Nov 28, 2024
36 checks passed
mbien pushed a commit to mbien/netbeans that referenced this pull request Nov 28, 2024
Revert "LSP: Speed up publish diagnostics on project scan."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests Regression This used to work!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBoundsException in JavaCustomIndexer$ErrorConvertorImpl
4 participants