Donate another batch of SVG icons #8083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the style of other NetBeans icons. The icons for OptionPane are 32x32 pixel version of the info/error/warning/question icons (scaled up from similar 16x16 SVG icons, but maintaining the 1px border width as this looks better). The icons for file chooser are "folder", "file", "parent folder", and "home folder". To keep the SVG loader module optional for NetBeans Platform apps, PNG versions of the icons are used here. SVG versions will be added in a separate commit (together with a bunch of other SVG files).
…on of the effort to make NetBeans look good on HiDPI/Retina screens. There are 99 new icons in total, copied into many more places where duplicate bitmap icons were identified. Some existing icons were also adjusted, and some existing icons were copied into new locations where additional duplicates were identified. I prioritized icons that are commonly seen in the IDE, and which happen to be easy to draw, as well as icons that are similar to already-drawn ones or simple variations or combinations thereof. The changes in this commit consist purely of copying SVG files into various locations in the repo; this was done by the hidpi-icons script at https://github.com/apache/netbeans-tools/tree/master/icon-scripts/hidpi-icons . I will open a separate Pull Request for that repo, to update the Adobe Illustrator file and icon mapping files. The 'icons.html' file that is generated by the hidpi-icons script is now included as part of the commit, in the root of the NetBeans repo. It includes a preamble with useful information and links to the README. See the Pull Request for screenshots.
eirikbakke
added
Look and Feel
Platform
eirikbakke
requested review from
mbien,
matthiasblaesing,
ebarboni,
Chris2011 and
neilcsmith-net
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is another batch of SVG icons for NetBeans, drawn by myself. This is a continuation of the effort to make NetBeans look good on HiDPI/Retina screens (see previous PRs).
There are 99 new icons in total. Many are used in multiple places in the codebase. See this generated page for a visual summary.
Some examples:
Some IDE icons now have SVG icons available, but still load their old PNG versions (e.g. the lightbulb hint icons in the first screenshot above). In these cases we will need to find the place in the codebase where icon loading happens, and change it manually. Automatic loading of SVG versions only happens when icons are loaded via ImageUtilities.loadImage or loadImageIcon, rather than e.g. "new ImageIcon()" or Toolkit.getImage. Such changes are left for future work (contributions welcome!)
There is a corresponding PR to the icon-scripts tool in the netbeans-tools repo, to add the latest version of the original Adobe Illustrator file and update file that specifies the mapping from bitmap to SVG icon files.