[NIFI-13470] Jolt codemirror linting #9068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scottyaslan
commented
Jul 10, 2024
scottyaslan
commented
scottyaslan
added
the
new ui
|
Will review... |
|
Reviewing now... |
|
+1 (non-binding). This LGTM. Tested by dropping a JoltTransformJSON processor on the canvas, opening the new Jolt UI and adding the processor id as a query param. Verified that linting is working as expected. |
mcgilman
reviewed
Jul 18, 2024
.../pages/jolt-transform-json-ui/state/jolt-transform-json-ui/jolt-transform-json-ui.reducer.ts
Outdated
Show resolved
Hide resolved
...ransform-ui/src/app/pages/jolt-transform-json-ui/feature/jolt-transform-json-ui.component.ts
Outdated
Show resolved
Hide resolved
...ransform-ui/src/app/pages/jolt-transform-json-ui/feature/jolt-transform-json-ui.component.ts
Outdated
Show resolved
Hide resolved
...ransform-ui/src/app/pages/jolt-transform-json-ui/feature/jolt-transform-json-ui.component.ts
Outdated
Show resolved
Hide resolved
mcgilman
reviewed
Jul 24, 2024
nifi-frontend/src/main/frontend/apps/nifi-jolt-transform-ui/src/app/app.module.ts
Outdated
Show resolved
Hide resolved
…state, and transform state separated in the store
mcgilman
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.