[NIFI-13535] - Fix: Issues selecting GitHub branch on version control screens in new UI #9087
Conversation
… screens in new UI
mcgilman
added
the
new ui
| @@ -212,7 +212,8 @@ export class ImportFromRegistry extends CloseOnEscapeDialog implements OnInit { | |||
| flowChanged(flowId: string): void { | |||
| const registryId = this.importFromRegistryForm.get('registry')?.value; | |||
| const bucketId = this.importFromRegistryForm.get('bucket')?.value; | |||
| this.loadVersions(registryId, bucketId, flowId); | |||
| const branch = this.importFromRegistryForm.get('branch')?.value; | |||
| this.loadVersions(registryId, bucketId, flowId, branch); | |||
There was a problem hiding this comment.
It looks like there is a similar function for bucketChanged which then calls loadFlows(registryId, bucketId) and I think that would need to include the branch as well right?
|
Also, we need the same behavior on the "Start Version Version Control" screen. I am not sure if that is backed by |
Start version control doesn't load flows or flow versions since we are adding a new flow to the repository. I'm not sure I understand what needs changed there. |
|
Will review... |
NIFI-13535
Properly include the branch query param in API calls to the backend registry API when provided.