Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13558 Configure Web Security to ignore unauthenticated requests #9090

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-13558 Updates the framework WebSecurityConfiguration to ignore requests that do not require authentication.

The previous approach applied Spring Security filter processing to all requests, but permitted access without authentication to specific paths required for user interface configuration. This approach works for the majority of situations where the user interface makes initial requests without authentication. For certain edge cases, the client browser will continue to send a session cookie with an application bearer token that may be expired. In this situation, unauthenticated paths should continue to return the same results.

The implementation changes make use of the securityMatchers method to specify the paths that the filter chain evaluates. The configuration updates apply filter evaluation to all requests, except those listed as unfiltered paths.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@mcgilman
Copy link
Contributor

Will review...

Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @exceptionfactory! I am verified the desired behavior for the endpoints which should work in an unauthenticated context.

@mcgilman mcgilman merged commit e35cbbb into apache:main Jul 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants