Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-13557 Corrected regular expression for short months in order to allow for single digit months. #9094

Closed
wants to merge 1 commit into from
Closed

NIFI-13557 Corrected regular expression for short months in order to allow for single digit months. #9094

wants to merge 1 commit into from

Conversation

dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Jul 19, 2024 •
edited
Loading

Summary

NIFI-13557
This fix corrects any 'Date Format' , 'Time Format' and 'Timestamp Format' (used in various record readers) to allow for reading single digit months. Before this fix whether a user specified MM or M only double digit months could be read. That logic was incorrect as the underlying code uses java.time.format.DateTimeFormatter and per the DateTimeFormatter javadoc specifying single digit month M should support both single and double digits.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

exceptionfactory
exceptionfactory approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, looks good! +1 merging

@dan-s1
Copy link
Contributor Author

dan-s1 commented Jul 22, 2024 •
edited
Loading

@exceptionfactory Thank you for merging this and #9096. Can this and #9096 also be included in the 1.x branch? Please let me know if I should submit separate PRs. Thanks!

exceptionfactory pushed a commit that referenced this pull request Jul 22, 2024
@dan-s1 @exceptionfactory
NIFI-13557 Corrected Date Time Matcher to support single digit months
b9b89ed 
This closes #9094

(cherry picked from commit 059a3b7)

Signed-off-by: David Handermann <exceptionfactory@apache.org>
@exceptionfactory
Copy link
Contributor

@dan-s1 I backported this change to the support branch. However, #9096 should not be backported because the change to use DateTimeFormatter is only on the main branch for NiFi 2.0.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Jul 22, 2024

@exceptionfactory Thank you for merging this to 1.x! Also thanks for pointing out about DateTimeFormatter. I had not realized it was only in 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-s1 @exceptionfactory