NIFI-13560 Change Parameter Provider handling to avoid storing values #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ParameterValueMapper for handling serialization of Parameter Values for Flow Configuration - Added Parameter Group retrieval method for Flow Synchronizer
bbende
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Code looks good, I was doing some testing using the KubernetesSecretParameterProvider just as way to easily use local files and I did a test where I stopped NiFi and moved the directory with the parameter groups, started NiFi back up and it got an exception on start up as expected:
2024-07-23 10:29:42,384 WARN [main] o.e.jetty.ee10.webapp.WebAppContext Failed startup of context oeje10w.WebAppContext@7c5c20ed{nifi-api,/nifi-api,b=file:///Users/bbende/Projects/nifi/nifi-assembly/target/nifi-2.0.0-SNAPSHOT-bin/nifi-2.0.0-SNAPSHOT/work/jetty/nifi-web-api-2.0.0-SNAPSHOT.war/webapp/,a=AVAILABLE,h=oeje10s.SessionHandler@350f18a6{STARTED}}{./work/nar/extensions/nifi-server-nar-2.0.0-SNAPSHOT.nar-unpacked/NAR-INF/bundled-dependencies/nifi-web-api-2.0.0-SNAPSHOT.war}
org.apache.nifi.controller.serialization.FlowSynchronizationException: java.lang.IllegalStateException: Error fetching parameters for ParameterProvider[id=dfef98ea-0190-1000-2666-d1d2efc702b2]: Cannot read the array length because "<local8>" is null
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.synchronizeFlow(VersionedFlowSynchronizer.java:459)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.sync(VersionedFlowSynchronizer.java:224)
at org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1718)
at org.apache.nifi.persistence.StandardFlowConfigurationDAO.load(StandardFlowConfigurationDAO.java:91)
at org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:811)
at org.apache.nifi.controller.StandardFlowService.load(StandardFlowService.java:532)
at org.apache.nifi.web.contextlistener.ApplicationStartupContextListener.contextInitialized(ApplicationStartupContextListener.java:67)
at org.eclipse.jetty.ee10.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:1591)
at org.eclipse.jetty.ee10.servlet.ServletContextHandler.contextInitialized(ServletContextHandler.java:497)
at org.eclipse.jetty.ee10.servlet.ServletHandler.initialize(ServletHandler.java:670)
at org.eclipse.jetty.ee10.servlet.ServletContextHandler.startContext(ServletContextHandler.java:1325)
at org.eclipse.jetty.ee10.webapp.WebAppContext.startWebapp(WebAppContext.java:1342)
at org.eclipse.jetty.ee10.webapp.WebAppContext.startContext(WebAppContext.java:1300)
at org.eclipse.jetty.ee10.servlet.ServletContextHandler.lambda$doStart$0(ServletContextHandler.java:1047)
at org.eclipse.jetty.server.handler.ContextHandler$ScopedContext.call(ContextHandler.java:1244)
at org.eclipse.jetty.ee10.servlet.ServletContextHandler.doStart(ServletContextHandler.java:1044)
at org.eclipse.jetty.ee10.webapp.WebAppContext.doStart(WebAppContext.java:499)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120)
at org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120)
at org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120)
at org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start(Server.java:624)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:120)
at org.eclipse.jetty.server.Handler$Abstract.doStart(Handler.java:491)
at org.eclipse.jetty.server.Server.doStart(Server.java:565)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:93)
at org.apache.nifi.web.server.JettyServer.start(JettyServer.java:863)
at org.apache.nifi.NiFi.<init>(NiFi.java:172)
at org.apache.nifi.NiFi.<init>(NiFi.java:83)
at org.apache.nifi.NiFi.main(NiFi.java:332)
Caused by: java.lang.IllegalStateException: Error fetching parameters for ParameterProvider[id=dfef98ea-0190-1000-2666-d1d2efc702b2]: Cannot read the array length because "<local8>" is null
at org.apache.nifi.controller.parameter.StandardParameterProviderNode.fetchParameters(StandardParameterProviderNode.java:286)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.getProvidedParameters(VersionedFlowSynchronizer.java:1017)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.getProvidedParameters(VersionedFlowSynchronizer.java:1010)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.createParameterMap(VersionedFlowSynchronizer.java:858)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.addParameterContext(VersionedFlowSynchronizer.java:808)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.inheritParameterContext(VersionedFlowSynchronizer.java:796)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.lambda$inheritParameterContexts$4(VersionedFlowSynchronizer.java:782)
at org.apache.nifi.controller.flow.AbstractFlowManager.withParameterContextResolution(AbstractFlowManager.java:668)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.inheritParameterContexts(VersionedFlowSynchronizer.java:774)
at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.synchronizeFlow(VersionedFlowSynchronizer.java:405)
... 39 common frames omitted
Caused by: java.lang.NullPointerException: Cannot read the array length because "<local8>" is null
at org.apache.nifi.parameter.KubernetesSecretParameterProvider.getParameterGroup(KubernetesSecretParameterProvider.java:191)
at org.apache.nifi.parameter.KubernetesSecretParameterProvider.lambda$fetchParameters$0(KubernetesSecretParameterProvider.java:133)
at java.base/java.lang.Iterable.forEach(Iterable.java:75)
at org.apache.nifi.parameter.KubernetesSecretParameterProvider.fetchParameters(KubernetesSecretParameterProvider.java:132)
at org.apache.nifi.controller.parameter.StandardParameterProviderNode.fetchParameters(StandardParameterProviderNode.java:284)
... 48 common frames omitted
The issue was that it did not fail start up, it continued on an said that JettyServer was started and printed the normal Started Server on https://localhost:8443/nifi.
It seems like we are trying to handle this case in JettyServer after calling start() we then check all the contexts to see if they have an unavailable exception, and if so then trigger shutdown, but that doesn't seem to be happening.
I realize this is somewhat unrelated to the changes in this PR, but since the expected behavior is to fail start up if unable to fetch parameters, I'm thinking maybe this should be improved. What do you think?
|
Thanks for the feedback and exercising the failure behavior @bbende. I agree that the JettyServer startup failure behavior should be adjusted. Although it is related, I think it would be better to consider that in a separate issue to consider general failure handling, to include this and other types of context initialization failures. |
|
I'm fine tackling the start up issue in a separate ticket since it is really an existing problem. Everything else is good here so +1 |
bbende
approved these changes
Jul 23, 2024
|
Thanks @bbende! I created NIFI-13575 to address the Jetty Server startup behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13560 Refactors Parameter Provider handling to avoid storing fetched Parameter Values in the persisted flow configuration.
The implementation change retains memory-based storage of fetched Parameter Values ,but stores a reference string in the serialized flow configuration. When the framework starts, the flow synchronization process fetches current values from referenced Parameter Providers.
This change requires configured Parameter Provider services to be accessible on startup, but otherwise retains existing behavior. This strategy restores centralized management of external Parameter Values to referenced external services. The nature of external vaults and secrets managers necessitates high availability, so the requirement for accessibility on application start should be reasonable for production deployments.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation