Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13590 Refactor components in standard-processors bundle using current API methods #9119

Closed
wants to merge 3 commits into from

Conversation

EndzeitBegins
Copy link
Contributor

@EndzeitBegins EndzeitBegins commented Jul 27, 2024

Summary

NIFI-13590

Makes use of the new APIs introduced for working with AllowableValue, e.g. in NIFI-12573 or NIFI-12452.
Makes use of newer Java APIs for declaring relationships and properties.
Applies some minor improvements recommended by IntelliJ available in newer Java versions.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@EndzeitBegins EndzeitBegins marked this pull request as draft July 27, 2024 14:37
@EndzeitBegins EndzeitBegins marked this pull request as ready for review July 28, 2024 12:19
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these improvements @EndzeitBegins. The changes look good in general, but the main recommendation is to keep one property descriptor and one relationship per line. This makes the list much easier to read, and easier to maintain when introducing changes. I noted a number of specific places for this, but did not note it on every Processor, although it applies to the majority of the changes.

@EndzeitBegins
Copy link
Contributor Author

EndzeitBegins commented Jul 29, 2024

Thank you for the quick review @exceptionfactory.
I've adjusted the property declarations accordingly.

Edit: Just noticed the other recommendations, will address those in another commit.

@EndzeitBegins
Copy link
Contributor Author

I've moved some more property declarations to static fields and removed the PROP_ prefix of serval properties as you've suggested @exceptionfactory.
I'd appreciate another review.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the formatting adjustments, and for bringing these components up to current implementation standards @EndzeitBegins! +1 merging

@EndzeitBegins EndzeitBegins deleted the NIFI-13590 branch August 2, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants