-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13590 Refactor components in standard-processors bundle using current API methods #9119
Conversation
481a702
to
83fead0
Compare
83fead0
to
d1dbf02
Compare
…rrent API methods
d1dbf02
to
058a551
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on these improvements @EndzeitBegins. The changes look good in general, but the main recommendation is to keep one property descriptor and one relationship per line. This makes the list much easier to read, and easier to maintain when introducing changes. I noted a number of specific places for this, but did not note it on every Processor, although it applies to the majority of the changes.
...le/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/DebugFlow.java
Outdated
Show resolved
Hide resolved
...standard-processors/src/main/java/org/apache/nifi/processors/standard/DeduplicateRecord.java
Outdated
Show resolved
Hide resolved
...i-standard-processors/src/main/java/org/apache/nifi/processors/standard/DetectDuplicate.java
Outdated
Show resolved
Hide resolved
...-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateJsonPath.java
Outdated
Show resolved
Hide resolved
...fi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EvaluateXQuery.java
Outdated
Show resolved
Hide resolved
...ndle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetSFTP.java
Outdated
Show resolved
Hide resolved
...standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
Outdated
Show resolved
Hide resolved
...-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java
Outdated
Show resolved
Hide resolved
...fi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoinEnrichment.java
Outdated
Show resolved
Hide resolved
...fi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoinEnrichment.java
Outdated
Show resolved
Hide resolved
Thank you for the quick review @exceptionfactory. Edit: Just noticed the other recommendations, will address those in another commit. |
I've moved some more property declarations to static fields and removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the formatting adjustments, and for bringing these components up to current implementation standards @EndzeitBegins! +1 merging
Summary
NIFI-13590
Makes use of the new APIs introduced for working with AllowableValue, e.g. in NIFI-12573 or NIFI-12452.
Makes use of newer Java APIs for declaring relationships and properties.
Applies some minor improvements recommended by IntelliJ available in newer Java versions.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation