-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-14230 Implement start/stop flow C2 operations in MiNiFi #9694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your change, @pkedvessy!
The approach looks good to me. I wrote some comments, please check them.
...le/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/C2HeartbeatFactory.java
Show resolved
Hide resolved
...vice/src/main/java/org/apache/nifi/c2/client/service/operation/StopFlowOperationHandler.java
Show resolved
Hide resolved
...src/test/java/org/apache/nifi/c2/client/service/operation/StartFlowOperationHandlerTest.java
Show resolved
Hide resolved
...ework/minifi-framework-core/src/main/java/org/apache/nifi/minifi/c2/C2NifiClientService.java
Outdated
Show resolved
Hide resolved
try { | ||
ProcessGroup rootProcessGroup = flowController.getFlowManager().getRootGroup(); | ||
if (rootProcessGroup != null) { | ||
rootProcessGroup.startProcessing(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly processGroup.startProcessing() starts the underlying process groups as well, so that seems to be okay. However it seems to be that the remote process groups need to be started/stopped manually, so we probably need to traverse the process groups recursively, and start the remote process groups on each levels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice catch. Recursive start/stop applied and the runStatus "calculation" updated as well with checking nested process groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the changes! Looks go to me. +1
Will proceed with the merge once the CI build is done
Summary
NIFI-14230
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation