Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14230 Implement start/stop flow C2 operations in MiNiFi #9694

Closed
wants to merge 1 commit into from

Conversation

pkedvessy
Copy link
Contributor

Summary

NIFI-14230

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [ x ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [ x ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [ x ] Pull Request based on current revision of the main branch
  • [ x ] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [ x ] Build completed using mvn clean install -P contrib-check
    • [ x ] JDK 21

Licensing

  • [ x ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ x ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ x ] Documentation formatting appears as expected in rendered files

@briansolo1985 briansolo1985 self-requested a review February 6, 2025 13:24
@briansolo1985 briansolo1985 added the minifi Pull requests that updates minifi/c2 codes label Feb 6, 2025
Copy link
Contributor

@briansolo1985 briansolo1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your change, @pkedvessy!
The approach looks good to me. I wrote some comments, please check them.

try {
ProcessGroup rootProcessGroup = flowController.getFlowManager().getRootGroup();
if (rootProcessGroup != null) {
rootProcessGroup.startProcessing();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly processGroup.startProcessing() starts the underlying process groups as well, so that seems to be okay. However it seems to be that the remote process groups need to be started/stopped manually, so we probably need to traverse the process groups recursively, and start the remote process groups on each levels

Copy link
Contributor Author

@pkedvessy pkedvessy Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch. Recursive start/stop applied and the runStatus "calculation" updated as well with checking nested process groups.

Copy link
Contributor

@briansolo1985 briansolo1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the changes! Looks go to me. +1
Will proceed with the merge once the CI build is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minifi Pull requests that updates minifi/c2 codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants