Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUTCH-3000 - the selenium protocol should return the full html, not just the inner body #773

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

tballison
Copy link
Contributor

…ust the inner body element.

Thanks for your contribution to Apache Nutch! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Nutch issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (NUTCH-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([NUTCH-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Java source code follows Nutch Eclipse Code Formatting rules
  • Nutch is successfully built and unit tests pass by running ant clean runtime test
  • there should be no conflicts when merging the pull request branch into the recent master branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled master branch.
  • if new dependencies are added,
    • are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
    • are LICENSE-binary and NOTICE-binary updated accordingly?

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Nutch in general, please sign up for the Nutch mailing list. Thanks!

@tballison tballison merged commit c1ba16c into apache:master Sep 13, 2023
1 check passed
@tballison tballison deleted the NUTCH-3000 branch September 13, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant