Skip to content

Commit

Permalink
Improved: Replace SvnCheckout in Gradle (OFBIZ-12868
Browse files Browse the repository at this point in the history
Comments out the pullPluginSource and pullAllPluginsSource Gradle tasks and
updates the documentation to use the pullPluginSource and pullAllPluginsSource
OS scripts
  • Loading branch information
JacquesLeRoux committed Jan 1, 2024
1 parent c7f606f commit 1eb5a52
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
23 changes: 12 additions & 11 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -692,24 +692,25 @@ If you need username and password to access the custom repository:
[[pull-an-official-plugin-from-source-control]]
=== Pull an official plugin from source control

Download an official plugin from source control (currently subversion) and place
it in the plugins directory. In addition, this task also executes the "install"
task if it is defined for the plugin being downloaded.
Download an official plugin from source control and place it in the plugins directory.
It's able to handle branches switches

This task is mostly useful when working on the trunk branch as it pulls in the
latest version of a plugin.

`gradlew pullPluginSource -PpluginId=ecommerce`
MS Windows: `pullPluginSource example` +
Unix-like OS: `./pullPluginSource.sh example`

[[pull-all-official-plugins-from-source-control]]
=== Pull all official plugins from source control

Download all officially supported plugins from source control (currently
git) and place them in /plugins.
It's able to handle branches switches

WARNING! This task deletes the /plugins directory and replaces it with the
official plugins.

`gradlew pullAllPluginsSource`
MS Windows: `pullAllPluginsSource` +
Unix-like OS: `./pullAllPluginsSource.sh`


This task makes it easy to download and develop officially supported plugins. It
is mostly used by developers or individuals working on the trunk branch. We do
Expand Down Expand Up @@ -809,9 +810,9 @@ as a replacement for both "special-purpose" and "hot-deploy".
If you need to load the components in the plugins directory in a specific order
place a component-load.xml file in the plugins directory listing the order.

To check out a plugin from source control use the *pullPluginSource* Gradle
task. To check out all plugins from source control use the
*pullAllPluginsSource*. *Beware* this deletes a previously existing plugins
To check out a plugin from source control use the Windows or Unix-like *pullPluginSource* script.
To check out all plugins from source control use the
*pullAllPluginsSource* script. *Beware* this deletes a previously existing plugins
directory.

[[running-gradle-tasks-without-an-internet-connection]]
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ task pullPlugin(group: ofbizPlugin, description: 'Download and install a plugin
}
}
}

/* The pullPluginSource and pullPluginSource task are now replaced by the OS scripts pullPluginSource and pullAllPluginsSource
task pullPluginSource(group: ofbizPlugin, description: 'Download and install a plugin from source control') {
if (project.hasProperty('pluginId')) {
Expand Down Expand Up @@ -1033,7 +1033,7 @@ task pullAllPluginsSource(group: ofbizPlugin,
doLast {
gradlewSubprocess(['installAllPlugins'])
}
}
}*/

// ========== Clean up tasks ==========
task cleanCatalina(group: cleanupGroup, description: 'Clean Catalina data in runtime/catalina/work') {
Expand Down

0 comments on commit 1eb5a52

Please sign in to comment.