Skip to content

Commit

Permalink
Fixed: Fix trunk documentation generation in BuidBot (OFBIZ-12896)
Browse files Browse the repository at this point in the history
It's a weird mess, maybe I miss something :/
Some same includes links that works well in 18.12 branch don't in trunk. I thought it could be due to java version but not even since I see that in the 18.12 build:

    To honour the JVM settings for this build a new JVM will be forked.
    > Task :deleteOfbizDocumentation
    > Task :generateOfbizDocumentation
    unsupported Java version "11", defaulting to 1.7
    BUILD SUCCESSFUL in 55s
    2 actionable tasks: 2 executed
  • Loading branch information
JacquesLeRoux committed Feb 8, 2024
1 parent 7f2e61c commit 836b55e
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ under the License.
As more explained at bottom of https://issues.apache.org/jira/browse/OFBIZ-11594, the introduction of "the SameSite attribute set to 'strict' for all cookies"
with https://issues.apache.org/jira/browse/OFBIZ-11470 prevents the internal Single Sign On feature.
There are ways to make it available as explained at bottom of https://issues.apache.org/jira/browse/OFBIZ-11594. It's not implemented OOTB
There are ways to make it available as explained at bottom of https://issues.apache.org/jira/browse/OFBIZ-11594.
It's not implemented OOTB
====


Expand Down Expand Up @@ -68,6 +68,8 @@ webappName.securedLoginId cookie, creates a JWT containing the userLoginId, and
. Then the sendJWT() Ajax function sends an Authorization header containing the JWT to the URL to reach.
At this stage, if all things are correct, the flow leaves the source side.

. *Last but not least*. To make this work you have to set the security.internal.sso.enabled and security.token.key SystemProperty entities locally and on trunk demo server

.On the server side:
. A CORS policy is needed. _Without it, the Authorization token containing the JWT will be rejected.
It's a simple policy but you need to strictly define the authorized domains. Never use the lazy "*" for domains
Expand Down

0 comments on commit 836b55e

Please sign in to comment.