Skip to content

Commit

Permalink
Implemented: Replace SvnCheckout in Gradle (OFBIZ-12868) (INFRA-25327)
Browse files Browse the repository at this point in the history
The pullAllPluginsSource.script is used in several CI places (GitHub actions,
BuildBot and Demos)

Lastly I committed the pullAllPluginsSource.sh and pullPluginSource.sh scripts
with Windows. As Windows has not the x flag, they were not set as executable.

This fixes it by setting them as executable using "git update-index --chmod=+x"

This also changes docker-image.yaml and gradle.yaml to use pullAllPluginsSource

I removed the build in docker-image.yaml as it's not longer needed. Only
pullAllPluginsSource was used and this task does not build anything. It just
pulls the sources

I did not set the the x flag for Windows  scripts as it will be useless anyway
since Windows does not use the x flag
  • Loading branch information
JacquesLeRoux committed Jan 1, 2024
1 parent fd52ae3 commit cdb3e6e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/docker-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ jobs:
java-version: 17
distribution: temurin
cache: 'gradle'
- name: Grant execute permission for gradlew
run: chmod +x gradlew
- name: Build with Gradle
run: ./gradlew pullAllPluginsSource
- name: Grant execute permission for gradlew and pullAllPluginsSource.sh
run: chmod +x gradlew pullAllPluginsSource.sh
- name: Load all plugins
run: ./pullAllPluginsSource.sh
- name: Determine metadata (tags, labels) for Docker framework with plugins build
id: pluginsmeta
uses: docker/metadata-action@507c2f2dc502c992ad446e3d7a5dfbe311567a96
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/gradle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,12 @@ jobs:
java-version: 17
distribution: temurin
cache: 'gradle'
- name: Grant execute permission for gradlew
run: chmod +x gradlew
- name: Grant execute permission for gradlew and pullAllPluginsSource.sh
run: chmod +x gradlew pullAllPluginsSource.sh
- name: Load all plugins
run: ./pullAllPluginsSource.sh
- name: Build with Gradle
run: ./gradlew pullAllPluginsSource check javadoc
run: ./gradlew check javadoc
# Below does not work, see see https://lists.apache.org/thread/80wzf4kclfk5nh2fss56jd6otf7y4n2f
# BuildBot does it anyway
# - name: Builds with Gradle, checks style and run integration tests (just to know if they pass)
Expand Down
Empty file modified pullAllPluginsSource.sh
100644 → 100755
Empty file.

0 comments on commit cdb3e6e

Please sign in to comment.