Fixed: Corrections based on Codenarc and Checkstyle errors (OFBIZ-10194)

apache · Feb 2, 2024 · e7502ac · e7502ac
1 parent 502c56b
commit e7502ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/applications/content/src/main/java/org/apache/ofbiz/content/content/ContentWrapper.java b/applications/content/src/main/java/org/apache/ofbiz/content/content/ContentWrapper.java
@@ -38,7 +38,7 @@
 public interface ContentWrapper {
 
     String MODULE = ContentWrapper.class.getName();
-    static final String CACHE_KEY_SEPARATOR = "::";
+    String CACHE_KEY_SEPARATOR = "::";
 
     StringUtil.StringWrapper get(String contentTypeId, String encoderType);
 

diff --git a/...ns/product/src/main/java/org/apache/ofbiz/product/product/ProductPromoContentWrapper.java b/...ns/product/src/main/java/org/apache/ofbiz/product/product/ProductPromoContentWrapper.java
@@ -117,7 +117,8 @@ public static String getProductPromoContentAsText(GenericValue productPromo, Str
         /* caching: there is one cache created, "product.promo.content"  Each productPromo's content is cached with a key of
          * contentTypeId::locale::mimeType::productPromoId, or whatever the CACHE_KEY_SEPARATOR is defined above to be.
          */
-        String cacheKey = productPromoContentTypeId + CACHE_KEY_SEPARATOR + locale + CACHE_KEY_SEPARATOR + mimeTypeId + CACHE_KEY_SEPARATOR + productPromo.get("productPromoId")
+        String cacheKey = productPromoContentTypeId + CACHE_KEY_SEPARATOR + locale + CACHE_KEY_SEPARATOR + mimeTypeId
+                + CACHE_KEY_SEPARATOR + productPromo.get("productPromoId")
                 + CACHE_KEY_SEPARATOR + encoderType + CACHE_KEY_SEPARATOR + delegator;
         String cachedValue = PRODUCT_PROMO_CONTENT_CACHE.get(cacheKey);
         if (cachedValue != null || PRODUCT_PROMO_CONTENT_CACHE.containsKey(cacheKey)) {