Skip to content

Commit

Permalink
Improved: Screen Communications in Party should not show create trigg…
Browse files Browse the repository at this point in the history
…er to user with VIEW permissions (OFBIZ-12891) (#688)

When accessing https://demo-trunk.ofbiz.apache.org/partymgr/control/FindCommunicationEvents as a user with only
VIEW permissions (.e.g. userId = auditor) the action trigger to create a new communication is shown.

This should not be visible to such a user as it leads to an undesired effect and diminished user experience.

modified:
- PartyMenus.xml - added permission condition to menu-item 'new' in CommSubTabBar
  • Loading branch information
PierreSmits committed Feb 6, 2024
1 parent 6708f75 commit eadf86a
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions applications/party/widget/partymgr/PartyMenus.xml
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,11 @@

<menu name="CommSubTabBar" extends="CommonButtonBarMenu" extends-resource="component://common/widget/CommonMenus.xml">
<menu-item name="new" title="${uiLabelMap.PartyNewCommunication}" widget-style="buttontext create">
<condition>
<or>
<if-has-permission permission="PARTYMGR" action="_CREATE"/>
</or>
</condition>
<link target="EditCommunicationEvent"/>
</menu-item>
<menu-item name="reply" title="${uiLabelMap.PartyReply}">
Expand Down

0 comments on commit eadf86a

Please sign in to comment.