Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Support "text" attribute on hyperlinks in forms (OFBIZ-12940) #725

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

florianMo
Copy link
Contributor

Fixed: OFBIZ-12940

Explanation
"text" attribute on hyperlinks in forms should define the modal title when used in "layered-modal" mode. Code indicates this intention (OfbizUtil.js, HtmlFormMacroLibrary.ftl) but the makeHyperlinkString Freemarker macro and the form renderer don't process this parameter. This commit fixes the modal title behavior in this context.

Thanks:
Néréide team

"text" attribute on hyperlinks in forms should define
the modal title when used in "layered-modal" mode. Code
indicates this intention (OfbizUtil.js, HtmlFormMacroLibrary.ftl)
but the makeHyperlinkString Freemarker macro and the form renderer
don't process this parameter. This commit fixes the modal title
behavior in this context.

OFBIZ-12940
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gilPts gilPts changed the title Fixed: Support "text" attribute on hyperlinks in forms Fixed: Support "text" attribute on hyperlinks in forms (OFBIZ-12940) Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant