Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Add permission check for view-maps and change defaults for request-maps (OFBIZ-13130) #831

Conversation

stschikin
Copy link
Contributor

Improved: Add permission check for view-maps and change defaults for request-maps (OFBIZ-13130)

Implemented an additional view-map parameter "auth" with a security check in RequestHandler.renderView. The default is set to "true".

The defaults for the request-map parameters "https" and "auth" were also changed to "true".

Alle request-maps and view-maps in framework, applications and plugins were checked and missing parameters were added to recreate to original functionality.

request-maps [(OFBIZ-13130)]

Adds an auth parameter to view-maps. The parameter is used in renderView
and initializes a security check.
request-maps [(OFBIZ-13130)]

Changes the defaults of the request-map parameters auth and https to
true.
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in framework to restore
the original functionality.
request-maps [(OFBIZ-13130)]

Adds missing view-map parameter in applications/accounting to restore
the original functionality.
request-maps [(OFBIZ-13130)]

Adds missing request-map parameter in applications/content to restore
the original functionality.
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in framework to restore
the original functionality.
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in applications/product to
restore the original functionality.
request-maps [(OFBIZ-13130)]

Adds missing request-map parameter in applications/workeffort to restore
the original functionality.
Copy link

sonarcloud bot commented Aug 16, 2024

@JacquesLeRoux JacquesLeRoux merged commit 9fe40f8 into apache:trunk Aug 23, 2024
6 checks passed
asfgit pushed a commit that referenced this pull request Aug 24, 2024
…request-maps (OFBIZ-13130) (#831)

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds an auth parameter to view-maps. The parameter is used in renderView
and initializes a security check.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Changes the defaults of the request-map parameters auth and https to
true.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in framework to restore
the original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing view-map parameter in applications/accounting to restore
the original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing request-map parameter in applications/content to restore
the original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in framework to restore
the original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing request- and view-map parameters in applications/product to
restore the original functionality.

* [Improved]: Add permission check for view-maps and change defaults for
request-maps [(OFBIZ-13130)]

Adds missing request-map parameter in applications/workeffort to restore
the original functionality.

Conflicts handled by hand (hopefully all correct, ain't easy)
 applications/order/webapp/ordermgr/WEB-INF/controller.xml
 framework/common/webcommon/WEB-INF/common-controller.xml
 framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants