adjust label order

apache · Aug 29, 2024 · 7f58c8c · 7f58c8c
1 parent 89dc5b8
commit 7f58c8c
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/core/src/layers/prometheus.rs b/core/src/layers/prometheus.rs
@@ -295,8 +295,8 @@ struct OperationLabels<'a> {
     namespace: &'a str,
     root: &'a str,
     op: Operation,
-    error: Option<ErrorKind>,
     path: &'a str,
+    error: Option<ErrorKind>,
 }
 
 impl<'a> OperationLabels<'a> {
@@ -310,14 +310,14 @@ impl<'a> OperationLabels<'a> {
             observe::LABEL_OPERATION,
         ]);
 
-        if error {
-            names.push(observe::LABEL_ERROR);
-        }
-
         if path_label_level > 0 {
             names.push(observe::LABEL_PATH);
         }
 
+        if error {
+            names.push(observe::LABEL_ERROR);
+        }
+
         names
     }
 
@@ -326,7 +326,7 @@ impl<'a> OperationLabels<'a> {
     /// 1. `["scheme", "namespace", "root", "operation"]`
     /// 2. `["scheme", "namespace", "root", "operation", "path"]`
     /// 3. `["scheme", "namespace", "root", "operation", "error"]`
-    /// 4. `["scheme", "namespace", "root", "operation", "error", "path"]`
+    /// 4. `["scheme", "namespace", "root", "operation", "path", "error"]`
     fn into_values(self, path_label_level: usize) -> Vec<&'a str> {
         let mut labels = Vec::with_capacity(6);
 
@@ -337,14 +337,14 @@ impl<'a> OperationLabels<'a> {
             self.op.into_static(),
         ]);
 
-        if let Some(error) = self.error {
-            labels.push(error.into_static());
-        }
-
         if path_label_level > 0 {
             labels.push(get_path_label(self.path, path_label_level));
         }
 
+        if let Some(error) = self.error {
+            labels.push(error.into_static());
+        }
+
         labels
     }
 }