Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some code in GitHub Actions #1269

Merged
merged 9 commits into from
Feb 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/bench.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
OPENDAL_FS_ROOT: /tmp/opendal/

- name: Store benchmark result
if: github.repository_owner == 'datafuselabs'
uses: benchmark-action/github-action-benchmark@v1
with:
name: Rust Benchmark
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
cp -r ./target/doc/* ./target/book

- name: Deploy to vercel
if: github.ref_name == 'main'
if: github.repository_owner == 'datafuselabs' && github.ref_name == 'main'
uses: amondnet/vercel-action@v25.1.1
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
Expand All @@ -48,7 +48,7 @@ jobs:
working-directory: ./target/book

- name: Deploy to vercel (preview)
if: github.ref_name != 'main'
if: github.repository_owner == 'datafuselabs' && github.ref_name != 'main'
uses: amondnet/vercel-action@v25.1.1
with:
vercel-token: ${{ secrets.VERCEL_TOKEN }}
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/service_test_ipmfs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@ concurrency:
jobs:
ipmfs:
runs-on: ubuntu-latest
services:
ipfs:
image: ipfs/go-ipfs:v0.14.0
ports:
- 5001:5001
steps:
- uses: actions/checkout@v3
- name: Set up IPFS ${{ matrix.ipfs }}
uses: ibnesayeed/setup-ipfs@b9b9f7d73db5f77d462225bb37dbd51153351dd9
id: ipfs_setup
with:
ipfs_version: "v0.14.0"
run_daemon: true
- uses: Swatinem/rust-cache@v2
- name: Test
shell: bash
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/service_test_redis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@ concurrency:
jobs:
redis:
runs-on: ubuntu-latest
services:
redis:
image: redis
ports:
- 6379:6379
steps:
- uses: actions/checkout@v3
- uses: shogo82148/actions-setup-redis@v1
with:
redis-version: "6.x"
- uses: Swatinem/rust-cache@v2
- name: Test
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ reqwest = { version = "0.11.13", features = [
"multipart",
"stream",
], default-features = false }
rocksdb = { version = "0.19", optional = true }
rocksdb = { version = "0.19", default-features = false, optional = true }
serde = { version = "1", features = ["derive"] }
serde_json = "1"
suppaftp = { version = "4.5", default-features = false, features = [
Expand Down
2 changes: 1 addition & 1 deletion src/services/rocksdb/backend.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use crate::*;
pub struct Builder {
/// The path to the rocksdb data directory.
datadir: Option<String>,
/// the working directory of the Redis service. Can be "/path/to/dir"
/// the working directory of the service. Can be "/path/to/dir"
///
/// default is "/"
root: Option<String>,
Expand Down