Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): public API of append #2284

Merged
merged 2 commits into from
May 22, 2023
Merged

feat(core): public API of append #2284

merged 2 commits into from
May 22, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented May 22, 2023 •
edited
Loading

This PR adds public API of append.

With four methods for the operator:

  • append
  • appender
  • append_with
  • appender_with

And async_write.

@suyanhanx
feat(core): public API of append
3866c47 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Xuanwo
Xuanwo reviewed May 22, 2023
View reviewed changes
core/src/types/operator/operator.rs Outdated Show resolved Hide resolved
core/src/types/operator/operator.rs Outdated Show resolved Hide resolved
@suyanhanx
remove needless use
e14a0c0 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Xuanwo
Xuanwo approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Please mark your PR as ready for review when you are ready for review instead a draft.

@Xuanwo Xuanwo marked this pull request as ready for review May 22, 2023 12:37
@Xuanwo Xuanwo merged commit 8532b4c into main May 22, 2023
@Xuanwo Xuanwo deleted the append-public branch May 22, 2023 12:37
@Xuanwo Xuanwo mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @Xuanwo