Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bindings/zig): enable tests and more #2375

Merged
merged 12 commits into from
May 31, 2023
Merged

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented May 31, 2023

Wait a bit for INFRA approve actions - #2374 actually won't run tests so it contains a wart 33650ae.

tisonkun added 7 commits May 31, 2023 12:24
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as draft May 31, 2023 05:37
@tisonkun
Copy link
Member Author

cc @kassane

tisonkun added 2 commits May 31, 2023 13:49
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review May 31, 2023 08:37
@tisonkun
Copy link
Member Author

Ready for review now

tisonkun added 2 commits May 31, 2023 16:39
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Xuanwo Xuanwo merged commit fd5a287 into apache:main May 31, 2023
@tisonkun tisonkun deleted the zig branch May 31, 2023 09:11
@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants