Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Don't wake up operator futures while not ready #2415

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix(core): Don't wake up operator futures while not ready #2415

merged 1 commit into from
Jun 5, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 5, 2023

Fix #2412

@Xuanwo
fix(core): Don't wake up operator futures while not ready
e96ca0a 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review June 5, 2023 07:54
@Xuanwo Xuanwo requested a review from suyanhanx June 5, 2023 07:57
ClSlaid
ClSlaid approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@ClSlaid ClSlaid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a series of blog posts are needed to explain how it broke and fixed

@Xuanwo Xuanwo merged commit fe21ea7 into main Jun 5, 2023
@Xuanwo Xuanwo deleted the fix-future branch June 5, 2023 08:07
suyanhanx
suyanhanx reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work.

@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx left review comments

@ClSlaid ClSlaid ClSlaid approved these changes

@PsiACE PsiACE PsiACE approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenDAL v0.36.0 on windows has a strange 60s hang
4 participants
@Xuanwo @suyanhanx @PsiACE @ClSlaid