Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings/haskell): post release 0.1.0 #2814

Merged
merged 5 commits into from
Aug 8, 2023
Merged

chore(bindings/haskell): post release 0.1.0 #2814

merged 5 commits into from
Aug 8, 2023

Conversation

silver-ymz
Copy link
Member

@silver-ymz silver-ymz commented Aug 8, 2023

I change cabal build system from default to custom script. With Setup.hs, cabal can call cargo build to manage the build of opendal-hs rust crate.

Now the problem is that rust crate is dynamic and haskell linker can't handle it. For each executable file built with opendal-hs, users must export env var LD_LIBRARY_PATH or use patchelf to set rpath.

And if we want to publish haskell library into hackage, we need to run cargo package first, and then do operation in packaged dir to make sure that the uploaded Cargo.toml does't depend on workspace.

Better solutions may need to wait haskell/cabal#9063 or haskell/cabal#7339

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 665d2c1 into main Aug 8, 2023
@Xuanwo Xuanwo deleted the haskell-release branch August 8, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants