Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(website): add local content search based on lunr plugin #4348

Merged
merged 3 commits into from
Mar 12, 2024
Merged

docs(website): add local content search based on lunr plugin #4348

merged 3 commits into from
Mar 12, 2024

Conversation

m1911star
Copy link
Contributor

@m1911star m1911star commented Mar 12, 2024 •
edited
Loading

2024-03-12.17.03.15.mov

Limitations:

for local pnpm start, it shows loading like below(readme doc updated)

截屏2024-03-12 17 01 04

ref:

@m1911star m1911star changed the title feat: add local content search based on lunr plugin docs(website): add local content search based on lunr plugin Mar 12, 2024
dqhl76
dqhl76 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! That's so cool. 🚀

Xuanwo
Xuanwo approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo
Copy link
Member

Xuanwo commented Mar 12, 2024

Ooops, please running npx license-checker --production --excludePrivatePackages --csv > DEPENDENCIES.node.csv to update the dep list of our website.

@m1911star
Copy link
Contributor Author

done

@dqhl76 dqhl76 merged commit bd3b8bd into apache:main Mar 12, 2024
11 checks passed
@suyanhanx
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqhl76 dqhl76 dqhl76 approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@xyjixyjixyji xyjixyjixyji Awaiting requested review from xyjixyjixyji

Assignees
No one assigned
Labels
releases-note/docs releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m1911star @Xuanwo @suyanhanx @dqhl76