-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ofs write behavior #4617
fix: ofs write behavior #4617
Conversation
cc @Xuanwo, PTAL |
drop(file); | ||
|
||
let mut file = File::open(&path).await.unwrap(); | ||
thread::sleep(Duration::from_secs(1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make sense to sleep 1s to make tests pass. We should fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked at #4636
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your effort!
* fix: ofs write behavior [wip] * fix: set `written` to end of the file when `is_append` * fix: ofs behavior tests * fix: clippy * ci: add timeout for ofs tests * ci * ci * fix: check flags * feat: file truncate test * fix * fix * refactor: readdirplus * fix: metadata from stat * chore * fix: dummy file attribute * fix: access * fix: read
lseek
implementation.write
.Metadata
.readdirplus
.merged #4611