refactor(core): Return unexpected error while content incomplete happen #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
requested review from
messense,
Zheaoli,
tisonkun and
PsiACE
as code owners
PsiACE
approved these changes
May 21, 2024
George-Miao
pushed a commit
to George-Miao/opendal
that referenced
this pull request
Jun 5, 2024
…en (apache#4633) Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to return two different errors,
ContentIncompleteandContentTruncated, when the HTTP response had too much or too little data. However, these error codes were not helpful to users as they provided no actionable steps.This PR addresses this issue by returning a generic unexpected error instead.