Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make AsyncBacktraceLayer covers oio::Read and oio::Write #4789

Merged
merged 3 commits into from
Jun 23, 2024
Merged

feat: make AsyncBacktraceLayer covers oio::Read and oio::Write #4789

merged 3 commits into from
Jun 23, 2024

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jun 23, 2024

Close: #4772

@PsiACE
feat: make AsyncBacktraceLayer covers oio::Read and oio::Write
804f9c7 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE PsiACE requested a review from dqhl76 June 23, 2024 04:19
@PsiACE PsiACE requested a review from Xuanwo as a code owner June 23, 2024 04:19
@PsiACE
feat: make cargo fmt happy
0cfd9cf 
Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE
refactor: use async fn directly
ad6d628 
Signed-off-by: Chojan Shang <psiace@apache.org>
Xuanwo
Xuanwo approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit ece83c9 into apache:main Jun 23, 2024
214 of 215 checks passed
@PsiACE PsiACE deleted the async-backtrace-rw branch June 24, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@dqhl76 dqhl76 Awaiting requested review from dqhl76

@oowl oowl Awaiting requested review from oowl

@Young-Flash Young-Flash Awaiting requested review from Young-Flash

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: AsyncBacktraceLayer covers oio::Read and oio::Write
2 participants
@PsiACE @Xuanwo