Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move ChunkedWrite logic into WriteContext #4826

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 30, 2024

Close #4800

This PR should not introduce breaking changes:

  • Chunked logic has never been implement for blocking write.
  • ChunkedWriter is no way to be used externally.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as draft June 30, 2024 08:23
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 30, 2024

Let's move this PR into next release.

@Xuanwo Xuanwo marked this pull request as ready for review July 1, 2024 08:49
@Xuanwo Xuanwo requested a review from suyanhanx as a code owner July 1, 2024 08:49
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 1c84223 into main Jul 1, 2024
253 checks passed
@Xuanwo Xuanwo deleted the move-chunked-write branch July 1, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idea: Move ChunkedWriter out to Writer
2 participants