Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core)!: from_map is now fallible #4917

Merged
merged 1 commit into from
Jul 20, 2024
Merged

feat(core)!: from_map is now fallible #4917

merged 1 commit into from
Jul 20, 2024

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jul 20, 2024 •
edited
Loading

This follows up #4915 and refers to #3240 .

@tisonkun
feat(core)!: from_map is now fallible
92569d1 
Signed-off-by: tison <wander4096@gmail.com>
Xuanwo
Xuanwo approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 1ad5b7a into main Jul 20, 2024
255 checks passed
@Xuanwo Xuanwo deleted the failable-build branch July 20, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tisonkun @Xuanwo