Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a helper macro to reduce the definition of root methods #5037

Closed

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Aug 23, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

To reduce boilerplate code; align the behaviors and docs.

What changes are included in this PR?

Are there any user-facing changes?

@Xuanwo
Copy link
Member

Xuanwo commented Aug 23, 2024

Thank you very much for your effort. However, OpenDAL aims to optimize code for readability. Repeating the code for root that doesn't change frequently is allowed and encouraged. Additionally, we prefer to avoid using macros whenever possible.

@yjhmelody
Copy link
Contributor Author

it is just simple optional macro

@Xuanwo
Copy link
Member

Xuanwo commented Aug 24, 2024

it is just simple optional macro

Thanks, but I don't want it.


We have a long-term goal to generate code for configuration and builders, but we are still working out the details: #4279

There is another idea that moving root to operator side: #4774

We often address problems in other ways instead of introducing macros, even when it's simple.

@yjhmelody
Copy link
Contributor Author

fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants