Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add list api for lakefs service. #5092

Merged
merged 6 commits into from
Sep 5, 2024
Merged

feat: add list api for lakefs service. #5092

merged 6 commits into from
Sep 5, 2024

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Sep 3, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@liugddx liugddx requested a review from Xuanwo as a code owner September 3, 2024 14:52
@liugddx liugddx marked this pull request as draft September 4, 2024 01:18
@liugddx liugddx marked this pull request as ready for review September 4, 2024 15:41
@liugddx
Copy link
Member Author

liugddx commented Sep 4, 2024

@Xuanwo PTAL

Xuanwo
Xuanwo reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall, this PR looks good to me. Here are a few minor suggestions for improvement.

core/src/services/lakefs/backend.rs Outdated Show resolved Hide resolved
core/src/services/lakefs/backend.rs Outdated Show resolved Hide resolved
core/src/services/lakefs/core.rs Outdated Show resolved Hide resolved
@liugddx
Copy link
Member Author

liugddx commented Sep 5, 2024

Thanks! Overall, this PR looks good to me. Here are a few minor suggestions for improvement.

PTAL

Xuanwo
Xuanwo approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit cf7b9ab into apache:main Sep 5, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liugddx @Xuanwo