Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(bindings/nodejs): Fix diff introduced by napi #5121

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 17, 2024

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: Xuanwo <github@xuanwo.io>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 17, 2024

Hi, @suyanhanx, thanks a lot for your review!

@Xuanwo Xuanwo merged commit fec524f into main Sep 17, 2024
69 checks passed
@Xuanwo Xuanwo deleted the fix-nodejs-diff branch September 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants