feat(bindings/ruby): Add I/O class for Ruby #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Dec 4, 2024
This reverts commit 99f8fdd.
Xuanwo
reviewed
Dec 6, 2024
bindings/ruby/Cargo.toml
Outdated
| @@ -18,7 +18,7 @@ | |||
| [package] | |||
| name = "opendal-ruby" | |||
| publish = false | |||
| version = "0.1.11" | |||
| version = "0.1.12" | |||
There was a problem hiding this comment.
We don't need to update it in this PR; the release manager will take care of it during the release.
There was a problem hiding this comment.
Thanks for future release manager!! Reverted
|
|
||
| Gem::Specification.new do |spec| | ||
| spec.name = "opendal" | ||
| spec.version = OpenDAL::VERSION | ||
| # RubyGems integrates and expects `cargo`. |
There was a problem hiding this comment.
It's a bit surprising to use json and need to call cargo for this. This might make things a bit complicated during the release process. However, it's fine for now; we can address it later.
There was a problem hiding this comment.
I agree with you.
If my memory checks out, RubyGems can also read a version file. At least I can do this manually. But I didn't find Cargo.toml supporting this.
This reverts commit 5ee304a.
|
Thanks for the review. I am 2-3 PRs away from achieving the issue. |
Xuanwo
approved these changes
Dec 6, 2024
Xuanwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5227.
Rationale for this change
An incremental update to Ruby binding work. This PR implements an
IOlike class.Many TODOs:
Are there any user-facing changes?
No.