refactor: tidy up oli build #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
PsiACE
approved these changes
Dec 22, 2024
Xuanwo
reviewed
Dec 22, 2024
| # Enable services memcached support | ||
| services-memcached = ["opendal/services-memcached"] | ||
| # Enable services mini-moka support | ||
| services-mini-moka = ["opendal/services-mini-moka"] |
There was a problem hiding this comment.
I believe we can remove all in-memory storage services, but redis and hdfs may still worth to support.
There was a problem hiding this comment.
This is an action that we don't need feature flags for CLI which is almost used as a binary.
I'll change the related features enabled in a follow-up when I touch it. Generally speaking we should include most services and remove those for memory. The two considerations are (1) if our CI workflow supports it (esp. for release) (2) if it significantly affects the binary size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step.