fix: python binding kwargs parsing #5458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
kwargs parsing is not correct with default pyo3 derive, it will try to parse from attribute instead of
dict.__getitem__
What changes are included in this PR?
Use
dict_derive
to parse struct from kwargs dict. Didn't find this in pyo3.another option is to remove
#[pyclass]
fromWriteOptions
and removem.add_class::<WriteOptions>()?
which may cause a breaking change and pyo3 doesn't support optional with#[pyo3(item)]
Are there any user-facing changes?
Yes,
op.write()
not support kwargs.