Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditional reader for azblob, gcs, oss #5531

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

geetanshjuneja
Copy link
Contributor

Which issue does this PR close?

Closes azblob, gcs, oss tasks for #5486.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please also enable the capability for those services so that we can cover them in the tests.

@Xuanwo Xuanwo changed the title Conditional reader for azblob, gcs, oss feat: Conditional reader for azblob, gcs, oss Jan 13, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @geetanshjuneja for working on this, let's merge!

@Xuanwo Xuanwo merged commit f951963 into apache:main Jan 13, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants