Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1381 - Fix OpenJDK 18+: CLITest fails with java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release #475

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Dec 30, 2022

What does this PR do?

  • Adds a build profile for JDK 18+, which allows the use of the SecurityManager via -Djava.security.manager=allow. Sadly, there is no replacement available yet. Other people deal with similar issues like in picocli: System.exit tests on Java 18 remkop/picocli#1503 - at the moment, it seems to be best to workaround the issue until the community finds proper solutions to deal with a (new?) SDK API to deal with it.
  • Adds Java 17, 18, 19 to the GitHub actions matrix build to ensure, that we are buildable (and testable) with new Java versions.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

…tedOperationException: The Security Manager is deprecated and will be removed in a future release
Copy link
Contributor

@mawiesne mawiesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rzo1 rzo1 merged commit f7c37fe into apache:main Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants