Proposed fix for Issue 60217

[leginee]

I have added the if clause, with the expectation it fullfills the goal czeslav formulated in comment 9

1. Truncated string
   It was fixed in version 3.0.0
   (cf. the attached file "juxtaVER.jpeg")

2. A spurious colon
   ralphie, comment #4

Furthermore, if there is no database selected, there is
a spurious colon after this sentence, see:

http://www.pangea.at/%7eralph/datenbank-austauschen.png

If no database is selected, there is a colon after the "sentence".
And the program unnecessarily displays a dot character.
(cf. the attached file "Period.jpg").

the source file: changedb.cxx
http://openoffice-vm1-he-de.apache.org/xref/trunk/main/sw/source/ui/fldui/changedb.cxx?r=efeef26f#333

333 void SwChangeDBDlg::ShowDBName(const SwDBData& rDBData)
334 {
335 String sTmp(rDBData.sDataSource);
336 String sName;
337 sTmp += '.';
338 sTmp += (String)rDBData.sCommand;
339
340 for (sal_uInt16 i = 0; i < sTmp.Len(); i++)
341 {
342 sName += sTmp.GetChar(i);
343 if (sTmp.GetChar(i) == '')
344 sName += '';
345 }
346
347 aDocDBNameFT.SetText(sName);
348 }

Look at the lines 335 - 338
I am not a software developer...
but if the properties "sDataSource" and "sCommand" are empty
then the programm should set the "sName" variable to empty
otherwise proceed as usual.

Did not build the PR. Needs testing, but can be a base of discussion.

[Pilot-Pirx]

The code does not compile:

Entering /cygdrive/c/Source/openoffice/main/sw/prj

cd .. && make -s -r -j1 && make -s -r deliverlog
[ build CXX ] sw/source/ui/fldui/changedb
changedb.cxx
c:/Source/openoffice/main/sw/source/ui/fldui/changedb.cxx(337) : error C2039: 'is' : is not a member of 'rtl::OUString'
C:/Source/openoffice/main/solver/420/wntmsci12.pro/inc\rtl/ustring.hxx(71) : see declaration of 'rtl::OUString'
c:/Source/openoffice/main/sw/source/ui/fldui/changedb.cxx(337) : error C2146: syntax error : missing ')' before identifier 'and'
c:/Source/openoffice/main/sw/source/ui/fldui/changedb.cxx(337) : error C2065: 'and' : undeclared identifier
c:/Source/openoffice/main/sw/source/ui/fldui/changedb.cxx(337) : error C2146: syntax error : missing ';' before identifier 'rDBData'
c:/Source/openoffice/main/sw/source/ui/fldui/changedb.cxx(337) : error C2039: 'is' : is not a member of 'rtl::OUString'
C:/Source/openoffice/main/solver/420/wntmsci12.pro/inc\rtl/ustring.hxx(71) : see declaration of 'rtl::OUString'
c:/Source/openoffice/main/sw/source/ui/fldui/changedb.cxx(337) : error C2059: syntax error : ')'
c:/Source/openoffice/main/sw/source/ui/fldui/changedb.cxx(337) : error C2143: syntax error : missing ';' before '{'
make: *** No rule to make target '/cygdrive/c/Source/openoffice/main/solver/420/wntmsci12.pro/workdir/CxxObject/sw/source/ui/fldui/changedb.o', needed by '/cygdrive/c/Source/openoffice/main/solver/420/wntmsci12.pro/workdir/LinkTarget/Library/iswui.lib'. Stop.
dmake: Error code 2, while making 'all'

1 module(s):
sw
need(s) to be rebuilt

[leginee]

Compiles now on docker container. Sadly the dockerbuild crashes on my system for some (other) reason.
SO I am not able to test now.

[Pilot-Pirx]

Builds now and the output looks like expected.
No dot when no database is selected.

[Pilot-Pirx]

If nobody else wants to review, It think we can merge this PR.

[ardovm]

LGTM
I suggest to squash these commits when merging.

[Pilot-Pirx]

@leginee: Can you please "squash and merge"?