Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the list of safe extensions #157

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Update the list of safe extensions #157

merged 2 commits into from
Oct 19, 2022

Conversation

ardovm
Copy link
Contributor

@ardovm ardovm commented Sep 30, 2022

The purpose of the extensions branch, and of this PR, is to add any missing entries to the list of "safe" file extensions.

Safe file extensions allow hyperlinks to be opened without asking for user confirmation.

Before this PR, the following extensions are considered safe:
1 123 602 aif aifc asf asx au avi bmp cgm csv dbf dib dif doc docm docx dot dotm dotx dxf emf eps fdf flac gif htm html jfif jif jpe jpeg jpg m1a m3u m4a met mid midi mml moov mov movie mp2 mp3 mpa mpe mpeg mpg odb odf odg odm odp ods odt ogg otg oth otp ots ott pbm pbm pcd pcd pct pcx pcx pdb pdf pgm pict png pot potm potx ppm pps ppt pptm pptx psd psw pxl qt ra ram ras rm rtf sda sdc sdd sdp sds sdw sgf sgl sgv shtml slk smf stc std sti stw svg svm sxc sxd sxg sxi sxm sxp sxw text tga tif tiff txt uof uop uos uot vor wav wb2 wk1 wks wmf wpl xbm xhp xhp xhtml xlc xlm xls xlsb xlsm xlsx xlt xltm xltx xlw xml xpm

The first commit adds mp4 to the above list.

@cbmarcum cbmarcum self-requested a review September 30, 2022 21:07
Copy link
Contributor

@cbmarcum cbmarcum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ardovm
Copy link
Contributor Author

ardovm commented Oct 1, 2022

Thank you @cbmarcum for your review.
More extensions are coming... please see this forum thread.

I think we can wait for one week to make sure everyone interested send their proposal.

Thanks to forum user MrProgrammer for the suggestion!
@ardovm ardovm merged commit 82b311e into trunk Oct 19, 2022
ardovm added a commit that referenced this pull request Oct 19, 2022
Add mp4 and High Efficiency Image File Format (HEIF) extensions to the safe list

Thanks to forum user MrProgrammer for the suggestion!

(cherry picked from commit 82b311e)
ardovm added a commit that referenced this pull request Oct 19, 2022
Add mp4 and High Efficiency Image File Format (HEIF) extensions to the safe list

Thanks to forum user MrProgrammer for the suggestion!

(cherry picked from commit 82b311e)
@ardovm ardovm deleted the extensions branch October 19, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants