Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fgrep is deprecated and may be removed soon, use grep -F instead #173

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

Pilot-Pirx
Copy link
Member

I am not a developer, so comments are welcome!

@Pilot-Pirx
Copy link
Member Author

The same is valid for egrep -> grep -E

@Pilot-Pirx Pilot-Pirx requested a review from ardovm March 8, 2023 16:35
Copy link
Contributor

@ardovm ardovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
However, I cannot find any invocation of the makedepn command.

@Pilot-Pirx
Copy link
Member Author

Pilot-Pirx commented Mar 18, 2023

http://opengrok.openoffice.org/xref/trunk/main/solenv/bin/srcrelease.xml?r=0f464f24#33

But here it is only excluded from the source build...
Maybe it is "dead" code?

@Pilot-Pirx Pilot-Pirx merged commit 710881b into trunk Mar 20, 2023
@Pilot-Pirx Pilot-Pirx deleted the Pilot-Pirx-grep branch March 20, 2023 16:52
asfgit pushed a commit that referenced this pull request Mar 20, 2023
* Update makedepn

* Minor change to commentregarding fgrep
(cherry picked from commit 710881b)
asfgit pushed a commit that referenced this pull request Mar 20, 2023
* Update makedepn

* Minor change to commentregarding fgrep
(cherry picked from commit 710881b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants