Remove unused(?) code #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gluepoint is actually generated here: https://github.com/apache/openoffice/blob/trunk/main/svx/source/sdr/primitive2d/sdrprimitivetools.cxx#L80 This part looks like a leftover for me. "SdrGluePoint::Draw" is only to be found in this file and nowhere else: http://opengrok.openoffice.org/search?project=trunk&full=%22SdrGluePoint%3A%3ADraw%22
aelnosu
reviewed
Apr 18, 2023
|
Once we delete the implementation of method Let us now check that this branch is still compiling. |
|
Thanks, I will check! Update: It builds fine! And the glue points in Draw are still there... |
ardovm
approved these changes
May 1, 2023
asfgit
pushed a commit
that referenced
this pull request
May 1, 2023
Remove unused(?) code and its declaration
asfgit
pushed a commit
that referenced
this pull request
May 17, 2023
Remove unused(?) code and its declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gluepoint is actually generated here:
https://github.com/apache/openoffice/blob/trunk/main/svx/source/sdr/primitive2d/sdrprimitivetools.cxx#L80
This part looks like a leftover for me.
"SdrGluePoint::Draw" is only to be found in this file and nowhere else: http://opengrok.openoffice.org/search?project=trunk&full=%22SdrGluePoint%3A%3ADraw%22
Any opinions?