Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused(?) code #177

Merged
merged 2 commits into from
May 1, 2023
Merged

Remove unused(?) code #177

merged 2 commits into from
May 1, 2023

Conversation

Pilot-Pirx
Copy link
Member

Gluepoint is actually generated here:
https://github.com/apache/openoffice/blob/trunk/main/svx/source/sdr/primitive2d/sdrprimitivetools.cxx#L80

This part looks like a leftover for me.

"SdrGluePoint::Draw" is only to be found in this file and nowhere else: http://opengrok.openoffice.org/search?project=trunk&full=%22SdrGluePoint%3A%3ADraw%22

Any opinions?

Gluepoint is actually generated here:
https://github.com/apache/openoffice/blob/trunk/main/svx/source/sdr/primitive2d/sdrprimitivetools.cxx#L80

This part looks like a leftover for me.

"SdrGluePoint::Draw" is only to be found in this file and nowhere else:
http://opengrok.openoffice.org/search?project=trunk&full=%22SdrGluePoint%3A%3ADraw%22
@Pilot-Pirx Pilot-Pirx requested a review from ardovm April 9, 2023 16:06
Copy link

@aelnosu aelnosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure that it is actually unused.😕

@ardovm
Copy link
Contributor

ardovm commented Apr 30, 2023

Once we delete the implementation of method SdrGluePoint::Draw, it is IMHO a good idea to delete its declaration as well. In this way, if any other piece of code refers to that method, it should not compile any more.

Let us now check that this branch is still compiling.

@Pilot-Pirx
Copy link
Member Author

Pilot-Pirx commented Apr 30, 2023

Thanks, I will check!

Update: It builds fine! And the glue points in Draw are still there...

Copy link
Contributor

@ardovm ardovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and compiles under Linux.

@ardovm ardovm merged commit 4bfd745 into trunk May 1, 2023
asfgit pushed a commit that referenced this pull request May 1, 2023
Remove unused(?) code and its declaration
asfgit pushed a commit that referenced this pull request May 17, 2023
Remove unused(?) code and its declaration
@Pilot-Pirx Pilot-Pirx deleted the Pilot-Pirx-glue branch July 2, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants