Skip to content

Commit

Permalink
MEECROWAVE-339: Only use proxy when not within proxy
Browse files Browse the repository at this point in the history
  • Loading branch information
ArneLimburg committed Sep 29, 2024
1 parent cf24941 commit 06cc7a6
Show file tree
Hide file tree
Showing 4 changed files with 62 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public MeecrowaveSecurityService(final WebBeansContext context) {
proxy = apiToProxy.length == 1 ? new MeecrowavePrincipal() : Principal.class.cast(
Proxy.newProxyInstance(loader, apiToProxy, (proxy, method, args) -> {
try {
return method.invoke(getCurrentPrincipal(), args);
return method.invoke(getUserPrincipal(), args);
} catch (final InvocationTargetException ite) {
throw ite.getTargetException();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,43 @@ protected Principal getPrincipal(final String username) {
}
}

@Test
public void runWithProxy() throws IOException {
String proxyApis = System.getProperty("org.apache.webbeans.component.PrincipalBean.proxyApis");
System.setProperty("org.apache.webbeans.component.PrincipalBean.proxyApis", "org.apache.meecrowave.TestPrincipal");
try (final Meecrowave container = new Meecrowave(new Meecrowave.Builder()
.randomHttpPort()
.includePackages("org.superbiz.app")
.realm(new RealmBase() {
@Override
protected String getPassword(final String username) {
return "foo".equals(username) ? "pwd" : null;
}

@Override
protected Principal getPrincipal(final String username) {
return new MyPrincipal(username);
}
}).loginConfig(new Meecrowave.LoginConfigBuilder()
.basic()
.realmName("basic realm"))
.securityConstraints(new Meecrowave.SecurityConstaintBuilder()
.authConstraint(true)
.addAuthRole("**")
.addCollection("secured", "/*")))
.bake()) {
assertEquals(
"org.apache.meecrowave.PrincipalTest$MyPrincipal_foo org.apache.webbeans.custom.Principal_foo",
slurp(new URL("http://localhost:" + container.getConfiguration().getHttpPort() + "/api/test/principal")));
} finally {
if (proxyApis != null) {
System.setProperty("org.apache.webbeans.component.PrincipalBean.proxyApis", proxyApis);
} else {
System.clearProperty("org.apache.webbeans.component.PrincipalBean.proxyApis");
}
}
}

private String slurp(final URL url) throws IOException {
final URLConnection is = HttpURLConnection.class.cast(url.openConnection());
is.setRequestProperty("Authorization", "Basic " + Base64.getEncoder().encodeToString("foo:pwd".getBytes(StandardCharsets.UTF_8)));
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.meecrowave;

public interface TestPrincipal {

}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
org.apache.webbeans.component.PrincipalBean.proxyApis=

0 comments on commit 06cc7a6

Please sign in to comment.