MEECROWAVE-341 fix maven-shade-plugin config

the old config did always create a dependency-reduced-pom which broke downstream projects
apache · Oct 20, 2024 · 2d27283 · 2d27283
1 parent 0c8574d
commit 2d27283
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/meecrowave-core/pom.xml b/meecrowave-core/pom.xml
@@ -18,12 +18,13 @@
     under the License.
 -->
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation=" http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+
   <parent>
     <artifactId>meecrowave</artifactId>
     <groupId>org.apache.meecrowave</groupId>
     <version>2.0.0-SNAPSHOT</version>
   </parent>
-  <modelVersion>4.0.0</modelVersion>
 
   <artifactId>meecrowave-core</artifactId>
   <name>Meecrowave :: Core</name>
@@ -63,7 +64,7 @@
       <groupId>org.apache.meecrowave</groupId>
       <artifactId>meecrowave-test-app</artifactId>
       <version>${project.version}</version>
-      <scope>provided</scope>
+      <scope>test</scope>
       <type>war</type>
     </dependency>
 
@@ -106,6 +107,7 @@
       <groupId>org.apache.openwebbeans</groupId>
       <artifactId>openwebbeans-se</artifactId>
       <version>${openwebbeans.version}</version>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>org.apache.openwebbeans</groupId>
@@ -431,6 +433,7 @@
             <configuration>
               <shadedClassifierName>runner</shadedClassifierName>
               <shadedArtifactAttached>true</shadedArtifactAttached>
+              <createDependencyReducedPom>false</createDependencyReducedPom>
               <dependencyReducedPomLocation>${project.build.directory}/reduced-pom-bundle.xml
               </dependencyReducedPomLocation>
               <transformers>

diff --git a/pom.xml b/pom.xml
@@ -206,6 +206,16 @@
   </dependencyManagement>
 
   <build>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-shade-plugin</artifactId>
+          <version>3.6.0</version>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+
     <plugins>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
@@ -216,12 +226,6 @@
         </configuration>
       </plugin>
 
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-shade-plugin</artifactId>
-        <version>3.6.0</version>
-      </plugin>
-
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-jar-plugin</artifactId>